Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:slider): add slider component #614

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

imguolao
Copy link
Contributor

fix #186

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 14, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #614 (86908cc) into main (ae3e9f1) will decrease coverage by 0.71%.
The diff coverage is 63.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   83.76%   83.05%   -0.72%     
==========================================
  Files         346      353       +7     
  Lines        8735     9089     +354     
  Branches     1960     2075     +115     
==========================================
+ Hits         7317     7549     +232     
- Misses       1418     1540     +122     
Impacted Files Coverage Δ
packages/components/input-number/src/types.ts 100.00% <ø> (ø)
packages/cdk/utils/src/dom.ts 76.54% <12.50%> (-7.02%) ⬇️
packages/components/slider/src/Marks.tsx 45.71% <45.71%> (ø)
packages/components/slider/src/useSlider.ts 57.97% <57.97%> (ø)
packages/components/slider/src/Steps.tsx 65.21% <65.21%> (ø)
packages/components/slider/src/Thumb.tsx 71.87% <71.87%> (ø)
...ages/components/input-number/src/useInputNumber.ts 87.37% <100.00%> (ø)
packages/components/slider/src/Slider.tsx 100.00% <100.00%> (ø)
packages/components/slider/src/token.ts 100.00% <100.00%> (ø)
packages/components/slider/src/types.ts 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3e9f1...86908cc. Read the comment docs.

@slider-marks-label-color: rgba(0, 0, 0, 0.451);

@slider-rail-bg: @background-color-base;
@slider-track-bg: #91d5ff;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件的颜色得换成 idux 的颜色变量。

packages/components/slider/style/index.less Outdated Show resolved Hide resolved
packages/components/slider/style/index.ts Outdated Show resolved Hide resolved
@danranVm danranVm merged commit 3bd3833 into IDuxFE:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: slider] add slider component
2 participants