-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move to pnpm #745
Conversation
This preview will be available after the AzureCI is passed. |
8acb264
to
7d73fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
顺便改一下 azure-pipelines.yml
里面的命令?
"lodash-es": "^4.17.21", | ||
"vue-types": "^3.0.0" | ||
}, | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compoents 应该没有依赖这两个库,是 site 的依赖。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compoents 应该没有依赖这两个库,是 site 的依赖。
我搜了一下,components下是有引用的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个是在 demo 里面用的,是输入 site 的代码。
components 的源码仅包含 src 目录下的。
@@ -126,6 +121,7 @@ | |||
"typescript": "^4.5.0", | |||
"unplugin-vue-components": "^0.17.0", | |||
"vite": "^2.7.0", | |||
"vue": "^3.2.29", | |||
"vue3-jest": "^27.0.0-alpha.2", | |||
"yaml-front-matter": "^4.1.1" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看看是否需要把gulp给加上,我本地尝试的时候,告诉我没有安装gulp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是有写glup的,是不是什么原因导致glup的bin没有生成?
3dfe4bc
to
10b71ff
Compare
a8d5282
to
ed932de
Compare
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 83.24% 83.19% -0.06%
==========================================
Files 461 461
Lines 12068 12065 -3
Branches 2869 2872 +3
==========================================
- Hits 10046 10037 -9
- Misses 2022 2028 +6
Continue to review full report at Codecov.
|
7290e09
to
e0da382
Compare
e0da382
to
5a88327
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
using yarn
What is the new behavior?
move to pnpm
Other information