refactor: move to pnpm #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
jackson-yyy
force-pushed
the
refactor-pnpm
branch
from
8acb264
to
7d73fe4
Compare
danranVm
requested changes
Feb 7, 2022
| "lodash-es": "^4.17.21", | ||
| "vue-types": "^3.0.0" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
compoents 应该没有依赖这两个库，是 site 的依赖。
There was a problem hiding this comment.
compoents 应该没有依赖这两个库，是 site 的依赖。
我搜了一下，components下是有引用的
There was a problem hiding this comment.
这两个是在 demo 里面用的，是输入 site 的代码。
components 的源码仅包含 src 目录下的。
liuzaijiang
reviewed
Feb 12, 2022
| @@ -126,6 +121,7 @@ | |||
| "typescript": "^4.5.0", | |||
| "unplugin-vue-components": "^0.17.0", | |||
| "vite": "^2.7.0", | |||
| "vue": "^3.2.29", | |||
| "vue3-jest": "^27.0.0-alpha.2", | |||
| "yaml-front-matter": "^4.1.1" | |||
| }, | |||
There was a problem hiding this comment.
看看是否需要把gulp给加上，我本地尝试的时候，告诉我没有安装gulp
There was a problem hiding this comment.
应该是有写glup的，是不是什么原因导致glup的bin没有生成？
jackson-yyy
force-pushed
the
refactor-pnpm
branch
3 times, most recently
from
3dfe4bc
to
10b71ff
Compare
jackson-yyy
force-pushed
the
refactor-pnpm
branch
7 times, most recently
from
a8d5282
to
ed932de
Compare
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 83.24% 83.19% -0.06%
==========================================
Files 461 461
Lines 12068 12065 -3
Branches 2869 2872 +3
==========================================
- Hits 10046 10037 -9
- Misses 2022 2028 +6
Continue to review full report at Codecov.
|
jackson-yyy
force-pushed
the
refactor-pnpm
branch
5 times, most recently
from
7290e09
to
e0da382
Compare
jackson-yyy
force-pushed
the
refactor-pnpm
branch
from
e0da382
to
5a88327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
using yarn
What is the new behavior?
move to pnpm
Other information