Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:stepper): redesign api #760

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #760 (b2484f7) into main (ac2579a) will decrease coverage by 0.05%.
The diff coverage is 92.72%.

❗ Current head b2484f7 differs from pull request most recent head fe319a7. Consider uploading reports for the commit fe319a7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   83.19%   83.14%   -0.06%     
==========================================
  Files         461      461              
  Lines       12073    12025      -48     
  Branches     2875     2866       -9     
==========================================
- Hits        10044     9998      -46     
+ Misses       2029     2027       -2     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/progress/src/types.ts 100.00% <ø> (ø)
packages/components/stepper/src/types.ts 100.00% <ø> (ø)
packages/components/stepper/src/Stepper.tsx 93.75% <88.88%> (+4.09%) ⬆️
packages/components/stepper/src/StepperItem.tsx 92.30% <92.85%> (-2.76%) ⬇️
packages/cdk/utils/src/vNode.ts 95.34% <100.00%> (-0.73%) ⬇️
packages/components/progress/src/ProgressInfo.tsx 91.30% <100.00%> (+0.39%) ⬆️
packages/components/stepper/src/token.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2579a...fe319a7. Read the comment docs.

@danranVm danranVm merged commit 623569d into IDuxFE:main Feb 18, 2022
@danranVm danranVm deleted the refactor-stepper branch February 18, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant