Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:utils): add prop types util #87

Merged
merged 1 commit into from
Dec 30, 2020
Merged

feat(cdk:utils): add prop types util #87

merged 1 commit into from
Dec 30, 2020

Conversation

danranVm
Copy link
Member

re #77

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #87 (1ac39a5) into main (fb395f2) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   94.21%   94.46%   +0.24%     
==========================================
  Files          40       41       +1     
  Lines         467      488      +21     
  Branches       85       85              
==========================================
+ Hits          440      461      +21     
  Misses         10       10              
  Partials       17       17              
Impacted Files Coverage Δ
packages/cdk/utils/propTypes.ts 100.00% <100.00%> (ø)
packages/components/badge/src/Badge.vue 100.00% <100.00%> (ø)
packages/components/button/src/Button.vue 100.00% <100.00%> (ø)
packages/components/button/src/ButtonGroup.vue 100.00% <100.00%> (ø)
packages/components/divider/src/Divider.vue 100.00% <100.00%> (ø)
packages/components/icon/src/Icon.vue 97.72% <100.00%> (+0.05%) ⬆️
packages/components/image/src/Image.vue 100.00% <100.00%> (ø)
packages/components/image/src/ImgPreview.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb395f2...1ac39a5. Read the comment docs.

@@ -70,7 +71,7 @@ async function appendChild(props: IconProps, iconConfig: IconConfig, root: Ref<H
}

function handleRotate(svg: SVGElement, rotate?: number | string | boolean): void {
if (typeof rotate === 'number' || typeof rotate === 'string') {
if (isNumber(rotate)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isNumber 需要替换个名字,现在的函数名有歧义。

@danranVm danranVm merged commit 33551ff into IDuxFE:main Dec 30, 2020
@danranVm danranVm deleted the valid-utils branch December 30, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant