Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: tree,tree-select,pro-tree): add getNode method (#910) #916

Merged
merged 1 commit into from
May 20, 2022

Conversation

tuchg
Copy link
Contributor

@tuchg tuchg commented May 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #916 (ea1b8f8) into main (fff5022) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ea1b8f8 differs from pull request most recent head 3abde54. Consider uploading reports for the commit 3abde54 to get more accurate results

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         679      679           
  Lines       66569    66648   +79     
  Branches     5875     5878    +3     
=======================================
+ Hits        62163    62242   +79     
  Misses       4406     4406           
Impacted Files Coverage Δ
...omponents/tree-select/__tests__/treeSelect.spec.ts 97.55% <100.00%> (+0.05%) ⬆️
packages/components/tree-select/src/TreeSelect.tsx 95.54% <100.00%> (+0.02%) ⬆️
packages/components/tree-select/src/types.ts 99.37% <100.00%> (+0.02%) ⬆️
packages/components/tree/__tests__/tree.spec.ts 100.00% <100.00%> (ø)
packages/components/tree/src/Tree.tsx 98.10% <100.00%> (+0.10%) ⬆️
packages/components/tree/src/types.ts 99.48% <100.00%> (+0.01%) ⬆️
packages/pro/tree/__tests__/proTree.spec.ts 100.00% <100.00%> (ø)
packages/pro/tree/src/ProTree.tsx 94.53% <100.00%> (+0.03%) ⬆️
packages/pro/tree/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff5022...3abde54. Read the comment docs.

@tuchg tuchg requested a review from danranVm May 19, 2022 04:28
@tuchg tuchg linked an issue May 19, 2022 that may be closed by this pull request
1 task
@tuchg tuchg changed the title feat(comp:tree,tree-select,pro-tree): add getNode method (#910) feat(comp: tree,tree-select,pro-tree): add getNode method (#910) May 19, 2022
packages/components/tree-select/docs/Index.zh.md Outdated Show resolved Hide resolved
packages/components/tree/src/Tree.tsx Outdated Show resolved Hide resolved
packages/components/tree-select/src/types.ts Outdated Show resolved Hide resolved
@tuchg tuchg requested a review from danranVm May 20, 2022 01:23
@danranVm danranVm merged commit 82c929d into IDuxFE:main May 20, 2022
@tuchg tuchg deleted the feat-tree-node branch May 26, 2022 04:06
@tuchg tuchg restored the feat-tree-node branch May 26, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pro:tree] 支持获取节点数据
2 participants