Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:all,pro:all,cdk:all): add eslint import check #922

Merged
merged 1 commit into from
May 24, 2022

Conversation

sallerli1
Copy link
Contributor

fix unresolved imports

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

eslint规则缺少Import检测,项目中存在部分不正确的import路径

What is the new behavior?

新增eslint-plugin-import相关配置

Other information

@idux-bot
Copy link

idux-bot bot commented May 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #922 (082600b) into main (f6652ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         679      679           
  Lines       66644    66644           
  Branches     5881     5881           
=======================================
  Hits        62238    62238           
  Misses       4406     4406           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6652ff...082600b. Read the comment docs.

@@ -32,7 +32,7 @@ const install = (app: App): void => {
const installer = { install, version }

export default installer
export { install, version }
export { install }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么把 version 都去掉了?

@danranVm danranVm merged commit 8bbbec1 into IDuxFE:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants