feat(comp: space): add component space #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 95.13% 95.54% +0.40%
==========================================
Files 42 45 +3
Lines 555 606 +51
Branches 97 108 +11
==========================================
+ Hits 528 579 +51
Misses 10 10
Partials 17 17
Continue to review full report at Codecov.
|
LaamGinghong
force-pushed
the
feature/space
branch
from
a898c20
to
55e70a2
Compare
|
@danranVm 麻烦安排一下review |
danranVm
requested changes
Jan 3, 2021
LaamGinghong
force-pushed
the
feature/space
branch
2 times, most recently
from
83ada1a
to
2c43db1
Compare
|
@danranVm 修改了一部分提出的问题，另一部分我提出了解答，麻烦请重新review |
LaamGinghong
force-pushed
the
feature/space
branch
5 times, most recently
from
a2263f6
to
de530f0
Compare
danranVm
requested changes
Jan 5, 2021
Comment on lines
+27
to
+28
| | `align` | 对齐方式 | `start \| center \| end \| baseline` | `baseline` | - | - | | ||
| | `direction` | 间距方向 | `vertical \| horizontal` | `horizontal` | - | - | |
There was a problem hiding this comment.
我想了下，这两个属性很难通用，基本都会单独配置，设置成全局好像不是很好
| <component :is="child.node" /> | ||
| </div> | ||
| <slot v-if="index < spaceList.length - 1" name="split"> | ||
| <span v-if="split" :key="child.id + 'span'" class="ix-space-split"> |
There was a problem hiding this comment.
你的 template 上已经绑定了一个 key, 这的 key 就没什么意义了吧。
LaamGinghong
force-pushed
the
feature/space
branch
3 times, most recently
from
4a9d878
to
ed38d5e
Compare
LaamGinghong
force-pushed
the
feature/space
branch
from
ed38d5e
to
b8a8251
Compare
danranVm
approved these changes
Jan 5, 2021
|
感谢你的 PR， LGTM. |
CruellyJoHn
pushed a commit
to CruellyJoHn/components
that referenced
this pull request
Jan 22, 2021
fix IDuxFE#77 build: upgrade vite (IDuxFE#102) refactor(comp:all): updalte all components ts definition (IDuxFE#103) docs: update all components index.zh.md (IDuxFE#105) * docs: update gen script fix(comp: divider): dynamic slot (IDuxFE#104) fix IDuxFE#76 feat(comp: spin): add spin component (IDuxFE#101) fix IDuxFE#72 refactor(comp:core): useGlobalConfig (IDuxFE#107) fix: vite traverse filename config (IDuxFE#106) docs: update spin component demo (IDuxFE#109) fix(comp: divider): slots rerender (IDuxFE#110) refactor(comp:i18n): update useI18n to useLocale (IDuxFE#111) feat(comp: space): add component space (IDuxFE#97) fix IDuxFE#63 fix(comp:all): solot dynamic load (IDuxFE#114) fix: add engines to package.json (IDuxFE#117) yarn start error because of the low version of Node.js fix IDuxFE#116 refactor: script gen type structure (IDuxFE#118) refactor: script gen types template (IDuxFE#119) * Update the template to make it more simpler. style(scripts): add brace style eslint rule (IDuxFE#123) fix IDuxFE#122 refactor(comp:all): export type declaration from current component (IDuxFE#124) docs: contribution (IDuxFE#125) update contributing.zh and add contributing.en fix(comp: image): export type to fix vite error (IDuxFE#127) feat(cdk:forms): add useFormControl and Validtors (IDuxFE#121) * test(cdk:forms): add test fix IDuxFE#115 docs(cdk:forms): add validators docs (IDuxFE#128) re IDuxFE#115 docs: modify components' docs' type (IDuxFE#131) feat(comp: empty): add component empty (IDuxFE#132) * feat(comp:empty): update and add test fix IDuxFE#54 feat(cdk:utils): add hasOwnProperty function (IDuxFE#137) fix(comp: badge): overflowCount not work (IDuxFE#135) fix IDuxFE#134 test(comp:badge,icon): fix warning (IDuxFE#140) feat(comp: result): add result component (IDuxFE#136) fix IDuxFE#112 feat(cdk:forms): add formGroup and formArray (IDuxFE#139) * feat(cdk:forms): add test re IDuxFE#115 feat(cdk:forms): add utils (IDuxFE#141) re IDuxFE#115 refactor(cdk:forms): `modelRef` renamed to `valueRef` (IDuxFE#142) re IDuxFE#115 feat(cdk:forms): add watchValue and watchStatus (IDuxFE#143) re IDuxFE#115 refactor(cdk:forms): add dirty status and marks `valueRef` to readonly (IDuxFE#144) re IDuxFE#115 feat(cdk:forms): setValue support configuration options (IDuxFE#146) re IDuxFE#115 feat: add global types (IDuxFE#150) docs(cdk:forms): add docs and demo (IDuxFE#149) fix IDuxFE#115 refactor(cdk:forms): update typescript defintions (IDuxFE#151) * docs(cdk:forms): update docs feat(cdk: subject): add subject (IDuxFE#155) fix IDuxFE#154 feat(comp: typography): add directive typography (IDuxFE#148) * docs(comp: typography): modify docs * feat(comp: typography): add type check * feat(comp: typography): style * test(comp: typography): add test fix IDuxFE#130 feature(comp:card): 1.修改dom结构 2.补全css样式 3.重跑单测 feat(comp:card): 1.解决合并冲突 feat(comp:card): add card component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #63
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information