Added test of turbine schema and fixed issues #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrbortolotti
approved these changes
Nov 27, 2024
|
[heart] Kenneth Lønbæk reacted to your message:
…________________________________
From: Pietro Bortolotti ***@***.***>
Sent: Wednesday, November 27, 2024 5:46:04 PM
To: IEAWindTask37/windIO ***@***.***>
Cc: Kenneth Lønbæk ***@***.***>; Author ***@***.***>
Subject: Re: [IEAWindTask37/windIO] Added test of turbine schema and fixed issues (PR #70)
@ptrbortolotti approved this pull request.
that's a welcome addition!
—
Reply to this email directly, view it on GitHub<#70 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARLM7XNX5346LWGUJ3UZ6JD2CYANZAVCNFSM6AAAAABSOXIXRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRVGY2TQNRYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a rather strict test of the turbine schema it self, by not allowing entries to be set outside of the schema it self.
It is also testing if entries in the
requiredandoptionallist are inproperties. Fx. I found that for the monopile it had requiredouter_shape_bembut its property wasouter_shape. I have not changed that to beouter_shape_bemfor the monopile.unitsis not a part of the standard schema, but I have manually added it to the schema - although only verifying that it is a string. There was also a mix ofunitsandunitwhere I have changed all to beunits.