Refine data models as agreed during further schema review meetings #46
Conversation
There was a problem hiding this comment.
@jonssonchristian all the content-related changes are fine and matches the outcomes of the discussions we had. The only thing to highlight is that the arrows in the diagrams seems to be shifted at serval locations.
|
Hi @AlinaBurmesterRWE, thank you very much for the quick review and feedback. Well spotted on the diagrams; I had not looked at those properly after the updated and noticed it. I had similar issues with rendering the diagrams previously. My suggestion would just be to leave it for now and try to fix it separately later on. For the internal schema review I think they are okay in the interim. For final documentation it will need fixed. Does that seem reasonable? |
There was a problem hiding this comment.
@jonssonchristian sounds reasonable. I guess there will be some changes in the next weeks and time spent might be waisted when diagram shifts again.
|
Great, thanks @AlinaBurmesterRWE. I will merge this now. I agree the diagram rendering is quite likely to break again. There is also an open issue on rendering it for the JSON Schema rather than from the Pydantic model: #42. Ideally I would like the final documentation to have diagrams with the JSON Schema types. |
Update the data models to incorporate changes agreed during the schema review sessions on the 13th and 27th of February 2024.