Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the turbine model and baseline power mode references with the Power Curve Schema #66

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

jonssonchristian
Copy link
Collaborator

@jonssonchristian jonssonchristian commented Nov 5, 2024

This PR addresses issue #56.

We have previously only had a placeholder turbine model identifier in the turbine configuration data model. This is here updated to reference the turbine model and baseline power mode with reference to the Power Curve Schema.

There is an open issue on the Power Curve Schema repo to clarify the best approach to this referencing, but there has not been a response yet. I do not see the need to wait for that. We can instead refine this later if we get suggestions for improvements.

This PR does not include example power curves and associated information according to the Power Curve Schema. That can be covered in a separate issue and PR.

@jonssonchristian jonssonchristian self-assigned this Nov 5, 2024
@jonssonchristian jonssonchristian changed the title Update external schema example references Align the turbine model and baseline power mode references with the Power Curve Schema Nov 26, 2024
@jonssonchristian
Copy link
Collaborator Author

Hi @momodiallosn, @bjarketol, @MeikeDittert,

I would like to test getting this PR reviewed an merged during the meeting today. I tag you here now to test if you get notified.

@jonssonchristian
Copy link
Collaborator Author

I have expanded this PR to also cover issue #69.

Copy link
Collaborator

@momodiallosn momodiallosn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements:

  • including TI range of power curves
    -refacto of code for test

@jonssonchristian
Copy link
Collaborator Author

Minor improvements:

  • including TI range of power curves
    -refacto of code for test

The power curve specifications are covered within the Power Curve Schema. The turbulence conditions for which the turbine is designed is covered under design bases, see here:

https://github.com/octue/power-curve-schema/blob/2b95e3b853d5f994ad06686e530a156caf298471/power-curve-schema/schema.json#L724

There are no upper and lower turbulence limits in that schema. If we think there should be, we should suggest it to the Power Curve Schema (IEC 61400-16) team.

@jonssonchristian
Copy link
Collaborator Author

Hi @momodiallosn, thank you very much for your input and feedback. I have now addressed all of your comments and pushed one update to the code. Let me know if you have any further comments or questions. We can also discuss during the upcoming meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants