-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align the turbine model and baseline power mode references with the Power Curve Schema #66
Conversation
…n-empty string type
…ons to revised data model for referencing a turbine model and baseline operating mode
Hi @momodiallosn, @bjarketol, @MeikeDittert, I would like to test getting this PR reviewed an merged during the meeting today. I tag you here now to test if you get notified. |
… example power curve documents
…Pydantic model instance
I have expanded this PR to also cover issue #69. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements:
- including TI range of power curves
-refacto of code for test
The power curve specifications are covered within the Power Curve Schema. The turbulence conditions for which the turbine is designed is covered under design bases, see here: There are no upper and lower turbulence limits in that schema. If we think there should be, we should suggest it to the Power Curve Schema (IEC 61400-16) team. |
Hi @momodiallosn, thank you very much for your input and feedback. I have now addressed all of your comments and pushed one update to the code. Let me know if you have any further comments or questions. We can also discuss during the upcoming meeting. |
This PR addresses issue #56.
We have previously only had a placeholder turbine model identifier in the turbine configuration data model. This is here updated to reference the turbine model and baseline power mode with reference to the Power Curve Schema.
There is an open issue on the Power Curve Schema repo to clarify the best approach to this referencing, but there has not been a response yet. I do not see the need to wait for that. We can instead refine this later if we get suggestions for improvements.
This PR does not include example power curves and associated information according to the Power Curve Schema. That can be covered in a separate issue and PR.