EnumMapper: Fix out-of-bounds read #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer dereferencing the component iterators (itItem and itName) of EnumMapper::Iterator until EnumMapper::Iterator itself is dereferenced. This prevents an out-of-bounds read when constructing an EnumMapper::Iterator from ::end() iterators.
frankplow
force-pushed
the
fix-enummapper-oob
branch
from
62cd901 to
a6843eb
Compare
|
Different solution implemented in #610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #607. Read there for some more details of the issue.
Defer dereferencing the component iterators (
itItemanditName) ofEnumMapper::IteratoruntilEnumMapper::Iteratoritself is dereferenced. This prevents an out-of-bounds read when constructing anEnumMapper::Iteratorfrom::end()iterators.Been a while since I've done any of this C++ STL stuff, so wouldn't mind some feedback. In particular, I wasn't sure the best way to make
operator->work. Thestd::unique_ptrapproach I've taken at the moment should work, despite not really returning anything that points to the internal values of theEnumMapper::Iterator— seeing as the returned pointer is markedconstthis doesn't really matter.