Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a forgotten load_dotenv #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions run.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def launch_hdf5(config: DictConfig):
launch_predict()

elif task_name == TASK_NAMES.HDF5.value:
dotenv.load_dotenv(override=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu peux en profiter pour rajouter un test qui vérifie que ce cas de figure fonctionne ?
j'ai l'impression que ça pourrait avoir sa plcate dans test_train_and_predict.py où il y a déjà des tests similaires (eg. test_predict_as_command)

launch_hdf5()

else:
Expand Down