Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-cell workbench - get_dataset_info.cgi needs to be faster #885

Closed
adkinsrs opened this issue Sep 11, 2024 · 4 comments
Closed

single-cell workbench - get_dataset_info.cgi needs to be faster #885

adkinsrs opened this issue Sep 11, 2024 · 4 comments
Assignees
Labels
code cleanup Fix the ugly, inefficient or just plain bad.

Comments

@adkinsrs
Copy link
Member

adkinsrs commented Sep 11, 2024

When selecting a dataset in the single-cell workbench, the get_dataset_info.cgi script can take several seconds. This includes nearly 15 seconds on one particular dataset I spot-checked. Currently there is no "loading" indicator to show things are happening and so people may think things have stalled.

@adkinsrs adkinsrs added the code cleanup Fix the ugly, inefficient or just plain bad. label Sep 11, 2024
@adkinsrs adkinsrs self-assigned this Sep 11, 2024
@adkinsrs
Copy link
Member Author

For comparison, get_dataset_list.cgi which returns multiple datasets (for the expression page) works in less than a second. Both servers create Dataset objects within

@adkinsrs
Copy link
Member Author

The get_dataset_info.cgi also returns the dataset shape (genes x cells) which requires reading the file into an AnnData object and determining the shape. That's the bottleneck.

@adkinsrs
Copy link
Member Author

Going to close this for now. We cannot really speed up the reading of the h5ad file per se, but I moved some code around so that a) the analyses are retrieved independently of the dataset information and b) the loading indicator shows while the dataset is retrieved instead of only for drawing the preliminary plots.

adkinsrs added a commit that referenced this issue Sep 11, 2024
@adkinsrs
Copy link
Member Author

Given my testing in #889 I think it may be wise to reopen this and change the shape retrieval in geardb to use the shadows package

@adkinsrs adkinsrs reopened this Sep 17, 2024
adkinsrs added a commit that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fix the ugly, inefficient or just plain bad.
Projects
None yet
Development

No branches or pull requests

1 participant