IGVF-1883 Add sample summary to analysis-set displays #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrohr
previously approved these changes
Sep 17, 2024
* Update npm packages. * Move file table to top of analysis-set pages. Add a Summary column to all file pages. * Update Tailwind CSS npm package. * Add `sample_summary` to object page. Add `summary` and `sample_summary` to list view. * Display the new `protocols` property on AnalysisSet objects from IGVF-1885. * Display `sample_summary` in the list-view summary section. Make the AnalysisSet `protocol` display conditional, at least until IGVF-1885 goes into dev. * Update Jest tests for the analysis-set list-view changes. * Update list view for AnalysisSet to not have `file_set_type` anymore, and remove the summary from the supplement section. * Update list-view to remove repetitiveness. Update Jest tests accordingly. * Only show supplement if alternate accessions or the sample summary exists.
forresttanaka
force-pushed
the
IGVF-1883-update-analysis-set-npm
branch
from
f042add
to
120c7da
Compare
Temporarily point this demo at the https://igvfd-igvf-1882-sample-summary.demo.igvf.org/ for that ticket’s QA. Revert this before merge.
Revert the last demo change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.