IGVF-1940 Allow user selection of audit columns on report views #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The audit checkboxes now select all three audit properties within an audit level, and it shows the proper audit checkboxes checked in reaction to the query-string audit properties. * Make audit columns non-sortable, because the sort= query-string has no effect on audit property order. * Properly count the number of selected columns, including each of the property columns for each audit level. Specify all the audit column properties in one place so we can change it reliably easily. * Handle disabling column checkboxes based on how many columns each one would add, so that audit checkboxes can disable themselves based on how many columns they would add. * Update Jest tests. * Update the Cypress tests. * Correct a comment.
mingjiecn
previously approved these changes
Sep 24, 2024
Forcing a 500 error on model-set pages to check something for regulome-ui. I’ll revert this later.
Sort details column by category and display as Markdown. Add Jest tests for the new audit cell renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.