IGVF-1989-rm-model-zoo #1164
Open
IGVF-1989-rm-model-zoo #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenjou
reviewed
Oct 31, 2024
| if 'model_zoo_location' in value: | ||
| model_zoo_location = value['model_zoo_location'] | ||
| value['url'] = model_zoo_location | ||
| notes += f' This model set has {model_zoo_location} in model_zoo_location, but the property model_zoo_location were removed via upgrade and should be submitted in url.' |
There was a problem hiding this comment.
Add a .strip() to remove extra white space (in case the object does not have any notes prior to this upgrade).
Also, I think the sentence can also be shortened, but depends how we decide on whether it will get added to url or not. Maybe something like one of these?
- The
model_zoo_locationof this model set was moved tourl. - This model set previously linked to [link] in
model_zoo_location, which has been removed via upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.