Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGVF-2097-file-facets #1205

Merged
merged 4 commits into from
Nov 19, 2024
Merged

IGVF-2097-file-facets #1205

merged 4 commits into from
Nov 19, 2024

Conversation

khzlin
Copy link
Contributor

@khzlin khzlin commented Nov 18, 2024

No description provided.

@khzlin khzlin requested a review from forresttanaka November 18, 2024 17:39
@forresttanaka
Copy link
Contributor

@khzlin Mapping conflict.

Copy link
Contributor

@forresttanaka forresttanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one feedback, but I’m not sure if it’s valid feedback or not.

src/igvfd/searches/configs/file.py Show resolved Hide resolved
@khzlin khzlin force-pushed the IGVF-2097-file-facets branch from 534842d to 7216396 Compare November 18, 2024 22:31
@khzlin khzlin requested a review from forresttanaka November 18, 2024 22:32
forresttanaka
forresttanaka previously approved these changes Nov 18, 2024
@khzlin khzlin force-pushed the IGVF-2097-file-facets branch from c2cb815 to 8fbe3e2 Compare November 19, 2024 20:09
@ottojolanki ottojolanki merged commit 0df0bbe into dev Nov 19, 2024
9 checks passed
@ottojolanki ottojolanki deleted the IGVF-2097-file-facets branch November 19, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants