IGVF-2113-index-file #1206
Merged
IGVF-2113-index-file #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-whaling
reviewed
Nov 18, 2024
src/igvfd/audit/file.py
Outdated
| "audit_description": "Alignment files in bai format are expected to have their corresponding bam file in `derived_from`.", | ||
| "audit_category": "incorrect bam file", | ||
| "audit_description": "Index files in tbi format are expected to have a corresponding tsv or vcf file in `derived_from`.", | ||
| "audit_category": "incorrect indexed file", |
There was a problem hiding this comment.
shouldn't this be "missing indexed file"?
There was a problem hiding this comment.
nevermind, I just realized derived_from is required for index files. But for consistency with the wording for other audits I think the category should be "unexpected indexed file" instead.
There was a problem hiding this comment.
BTW you should add this file type to the list of audit scripts in commands/make_audit_docstring.py
ian-whaling
reviewed
Nov 18, 2024
Comment on lines
+107
to
+110
| "enum": [ | ||
| "index" | ||
| ], |
There was a problem hiding this comment.
can you provide enum_descriptions?
ian-whaling
reviewed
Nov 18, 2024
| "$merge": [ | ||
| "file.json#/dependentSchemas" | ||
| ], | ||
| "file_format": { |
There was a problem hiding this comment.
can you leave comments for these dependencies
ian-whaling
requested changes
Nov 18, 2024
ian-whaling
previously approved these changes
Nov 19, 2024
jenjou
force-pushed
the
IGVF-2113-index-file
branch
from
b6e629f to
c494486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.