IGVF-2288-nucleic-acid-delivery #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 10, 2025 16:47
ian-whaling
reviewed
Feb 11, 2025
src/igvfd/audit/sample.py
Outdated
Comment on lines
233
to
234
| if 'construct_library_sets' in value and len(value['construct_library_sets']) > 0: | ||
| if 'nucleic_acid_delivery_method' not in value: |
There was a problem hiding this comment.
This can just be one line if 'construct_library_sets' in value and 'nucleic_acid_delivery_method' not in value:
added 3 commits
February 10, 2025 17:52
ian-whaling
previously approved these changes
Feb 11, 2025
ian-whaling
reviewed
Feb 11, 2025
| @@ -1,5 +1,9 @@ | |||
| ## Changelog for *`in_vitro_system.json`* | |||
|
|
|||
| ### Minor changes since schema version 25 | |||
|
|
|||
| * Extend `nucleic_acid_delivery` enum list to include `lipofectamine` and `electroporation`. | |||
There was a problem hiding this comment.
I think each addition should be one line each according to the standards we set for changelogs.
ian-whaling
requested changes
Feb 11, 2025
ian-whaling
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.