SNO2-71-block-float-ints #1323
Merged
SNO2-71-block-float-ints #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-whaling
reviewed
Feb 14, 2025
| item = alignment_file_v11.copy() | ||
| item.update( | ||
| { | ||
| 'schema_version': '11', |
There was a problem hiding this comment.
'schema_version': '12'
ian-whaling
reviewed
Feb 14, 2025
|
|
||
| @pytest.fixture | ||
| def alignment_file_v12(alignment_file_v11): | ||
| item = alignment_file_v11.copy() |
There was a problem hiding this comment.
I'd suggest just copying the base fixture alignment_file, the versioned fixtures typically have deprecated properties/values. won't cause any problems here but it can in theory
ian-whaling
reviewed
Feb 14, 2025
|
|
||
| @pytest.fixture | ||
| def sequence_file_v14(sequence_file_v12): | ||
| item = sequence_file_v12.copy() |
There was a problem hiding this comment.
I'd suggest just copying the base fixture sequence_file for the same reason as above
ian-whaling
previously approved these changes
Feb 14, 2025
hitz
reviewed
Feb 15, 2025
cdk/infrastructure/config.py
Outdated
| @@ -62,7 +62,7 @@ | |||
| 'construct_id': 'Postgres', | |||
| 'on': True, | |||
| 'props': { | |||
| 'snapshot_source_db_identifier': DEV_DATABASE_IDENTIFIER, | |||
| 'snapshot_source_db_identifier': PROD_DATABASE_IDENTIFIER, | |||
There was a problem hiding this comment.
why did snapshot identifier change from DEV_DATABASE_IDENTIFIER to PROD_DATABASE_IDENTIFIER? just want to make sure it's your intent to make this change.
hitz
previously approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.