IGVF-2381-genomic-elements #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-whaling
reviewed
Feb 21, 2025
| @@ -1,5 +1,10 @@ | |||
| ## Changelog for *`reference_file.json`* | |||
|
|
|||
| ### Schema version 16 | |||
|
|
|||
| * Adjust `content_type` enum list to disallow `regulatory_regions` for all users and admins. | |||
There was a problem hiding this comment.
Adjust content_type enum list to remove regulatory_regions.
ian-whaling
reviewed
Feb 21, 2025
| ### Schema version 16 | ||
|
|
||
| * Adjust `content_type` enum list to disallow `regulatory_regions` for all users and admins. | ||
| * Extend `content_type` enum list to include `genomic_elements` for admins. |
There was a problem hiding this comment.
Don't think you need to say "for admins"
There was a problem hiding this comment.
I added it since users can't use this property
ian-whaling
approved these changes
Feb 21, 2025
ian-whaling
requested changes
Feb 21, 2025
ian-whaling
previously approved these changes
Feb 21, 2025
ian-whaling
previously approved these changes
Feb 23, 2025
meenakshikagda
force-pushed
the
IGVF-2381-genomic-elements
branch
from
d627aa4 to
28a4a9c
Compare
ian-whaling
reviewed
Feb 24, 2025
| @@ -199,7 +199,7 @@ | |||
| "variants_proteins_terms", | |||
| "variants_proteins_biosamples", | |||
| "variants_proteins_phenotypes", | |||
| "variants_regulatory_regions", | |||
| "variants_genetic_elements", | |||
There was a problem hiding this comment.
genomic_elements not genetic_elements
ian-whaling
approved these changes
Feb 24, 2025
added 13 commits
February 25, 2025 14:31
ottojolanki
force-pushed
the
IGVF-2381-genomic-elements
branch
from
5a449c6 to
05d7934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.