Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGVF-1306 upload-storage-service #728

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

IGVF-1306 upload-storage-service #728

wants to merge 5 commits into from

Conversation

gabdank
Copy link
Contributor

@gabdank gabdank commented Dec 12, 2023

No description provided.

@gabdank gabdank changed the title IGVF-1305 add upload-storage-service IGVF-1306 add upload-storage-service Dec 12, 2023
@gabdank gabdank changed the title IGVF-1306 add upload-storage-service IGVF-1306 upload-storage-service Dec 12, 2023
iyoungworth
iyoungworth previously approved these changes Dec 12, 2023
Copy link
Contributor

@iyoungworth iyoungworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date on abstract File changelog should be updated to planned release date, but otherwise looks good

@@ -1,4 +1,5 @@
## Changelog for *`file.json`*

* Add and require `upload_storage_service`. (12/11/2023)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but this should be updated to date of release (planned 12/14/2023)

Copy link
Contributor Author

@gabdank gabdank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add enum for azure: azblob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants