IGVF-1686-software-version-req #933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenjou
force-pushed
the
IGVF-1686-software-version-req
branch
from
84ec9e7
to
2b51970
Compare
gabdank
force-pushed
the
IGVF-1686-software-version-req
branch
from
2b51970
to
3e59961
Compare
jenjou
force-pushed
the
IGVF-1686-software-version-req
branch
from
3e59961
to
9407b63
Compare
gabdank
force-pushed
the
IGVF-1686-software-version-req
branch
from
9407b63
to
48981ec
Compare
gabdank
requested changes
Jun 7, 2024
| merged_note = ' '.join([x for x in [software_note, version_note, lab_note, award_note] if x != '']) | ||
| notes = value.get('notes', '') | ||
| notes += merged_note | ||
| value['notes'] = notes.strip() |
There was a problem hiding this comment.
if for unknown to me reason the notes remain empty your upgrade is going to cause validation error, since you are assigning '' value to notes and that is invalid
jenjou
force-pushed
the
IGVF-1686-software-version-req
branch
from
48981ec
to
47e5cf3
Compare
gabdank
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.