ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames() #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has a hard depdendency to 'psutil' but is only required when IHP_PYCELL_LIB_PRINT_PROCESS_TREE is set. Move 'getProcessNames' inside the if block to allow using this PDK without 'psutil' installed. Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
dnltz
requested review from
KrzysztofHerman and
sergeiandreyev
as code owners
|
The chain of processes via getProcessNames() is needed in any case (for the conditional compilation of PyCells via #ifdef), independent of IHP_PYCELL_LIB_PRINT_PROCESS_TREE, see line |
Can you please point me to the location where it's used? This is IMO a huge issue. See #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has a hard depdendency to 'psutil' but is only required when IHP_PYCELL_LIB_PRINT_PROCESS_TREE is set. Move 'getProcessNames' inside the if block to allow using this PDK without 'psutil' installed.
Fixes #226