Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds accessibility enhancements #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mejackreed
Copy link

No description provided.

Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR got lost here years ago, but I found it during a UV accessibility sprint. Seems worth finishing up.

I'm going to guess that this is no longer on @mejackreed's radar or in scope for his work, but if he's interested in proceeding, he can let me know. Otherwise, I'll see if I can find a different volunteer! :-)

@@ -44,13 +44,13 @@ namespace IIIFComponents {
this._$rightOptions = $('<div class="right"></div>');
this._$header.append(this._$rightOptions);

this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" />');
this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" aria-label="Reduce Thumbnail Size"/>');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revise this to make the text i18n-friendly. I believe the way to do this is to add strings to the content element returning IGalleryComponentData in the data() method. Then the values can be overridden in the UV's getGalleryData method.

@demiankatz
Copy link
Contributor

It also looks like there are conflicts that need to be resolved here; it may make the most sense to just close this and rebuild from the diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants