Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading_gif closes #67 #71

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ConorSheehan1
Copy link
Contributor

@ConorSheehan1 ConorSheehan1 commented Dec 21, 2018

Closes #67
Would also recommend closing #69 first,
otherwise the page looks like it's loading forever when it can't reach the manifest.

Also, is the gif licence ok? It's under cc-sa, found on wikimedia.
If not I can try to find something fully cc-0?

Use cc-0 loading gif from https://loading.io/

@coveralls
Copy link

coveralls commented Dec 21, 2018

Coverage Status

Coverage decreased (-0.4%) to 83.2% when pulling f673f9a on ConorSheehan1:loading_gif into e620780 on IIIF:master.

@ConorSheehan1
Copy link
Contributor Author

ConorSheehan1 commented Apr 25, 2019

python 3.3 build failing to install lxml.
This lxml version requires Python 2.7, 3.4 or later.

Also issue with pyld (dependency of iiif_prezi) which uses asyncio,
since it wasn't included in stdlib until python 3.4.

async def async_loader(url):
            ^
SyntaxError: invalid syntax

python 3.3 is at EOL anyway, so might make sense to drop support?
https://www.python.org/dev/peps/pep-0398/#x-end-of-life

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate the validation is working
2 participants