Error for references in mdl or cst guards #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in issue #133, a guard like
(= A x)in a model or cst does not have the expected result. This is because the code for the guard checker doesn't support references to an object likex. Adding support for references in guards is more difficult than expected, so this pull request is a temporary solution to show an error if the uses adds a model or cst to the seed code where the guard has a referenced object.This pull request has two commits. The first commit adds the utility method
has_referenceto theUtilsclass. The second commit uses it in_Mem::load: As the objects from the seed code are being loaded, it checks if the guards of each model or cst has a referenced object. If so, it prints an error like the following and quits.