Remove unused support for enable_assumptions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssumptions. See pull request #221.
jefft0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit added support for the
enable_assumptionsflag insettings.xmlwith a default ofno. This was added when it was observed that a model controller would inject an assumption and then later make a prediction from the same assumption as if it were a normal fact. The controller code already had a mechanism to prevent this, but there was a bug which was recently discovered and fixed in pull request #220 . Therefore it is OK to let the model controller inject assumptions as designed, This pull request reverts the earlier commit to remove theenable_assumptionsflag.