Break up main into separate files and added CPU timeline #15
Conversation
Added CPU timeline
analysis/inter_trial_analysis.py
Outdated
| populate_fps(trials, replaced_names) | ||
| populate_cpu(trials, replaced_names) | ||
| populate_gpu(trials, replaced_names) | ||
| populate_power(trials, replaced_names) | ||
| populate_mtp(trials, replaced_names) |
There was a problem hiding this comment.
There seems to be a lot of similar code in these populate_x functions. Try to see if there is some way of creating a generic populate function so we don't have to have so much repeating code.
| stacked_cpu_time(data) | ||
| stacked_gpu_time(data) |
There was a problem hiding this comment.
Another area where there is repetitive code. Try to make a generic stacked graph function that you can pass either gpu, cpu, or energy data.
…nto improved-script
…nto improved-script
…nto improved-script
…nto improved-script
…nto improved-script
…nto improved-script
|
This is great work but I'm wondering if we should set a checkpoint and merge with master soon. Otherwise, reviewing/maintenance will keep getting progressively difficult. |
|
Everything works except Jeffrey's graphs, which I think work, but I can't test because I don't have the right data. I propose @JeffreyZh4ng helps me get the data, I hotfix the new graphs, and then merge with master. |
|
From here, we plan to fix areas where things are repetitive and speed up the CPU timeline graph. |
@charmoniumQ @lauren45983 someone should merge in isca-huzaifa-results branch to this one because that's where I did most of the work on the graphs. I believe it also has data |
No description provided.