bh-currency-select throws an unhandled error on initialise (low priority)

[sfount]

During testing of the cash module in #3095 it was noted that the bh-currency-select component always throws an undhandled error.

TypeError: Cannot read property 'currency' of undefined

This issue has never been reported as a bug so it doesn't look like it has an impact on the end users experience however it comes up frequently as this component is used in multiple places. It would be good to clean this up so that future changes can be built with a clean log.

The validation method on the component references a form attribute on the component that does not exist, it looks like this was potentially introduced as a work around to a previous version of angular's ng-form

As I understand the code there are two possible solutions:

1. Remove the code directly, I will follow up with tests but I believe the component works without directly setting the $valid property of the underlying form elements.

• Test the component with different inputs to ensure it works without the legacy code

2. The sub form elements can be exposed to the controllers scope by using an ng-form wrapper around the currency select inputs. This would expose the $setValidity method that the current controller expects to exist. for example:

<!-- Attach 'form' to the components scope -->
<div ng-form="$ctrl.form">
   <!-- Currency select HTML inputs -->
</div>

[sfount]

The component's validation behaviour works as expected with brief testing:

With one of the cash box currencies disabled:

With both of the cash box currencies disabled:

The error message shown is correct and the disabled/ valid attributes correctly propagate down form elements. It should be good to just remove the offending line of code as a legacy workaround.