chore: remove Topic #3105
Merged
chore: remove Topic #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
chore-rm-Topic
branch
2 times, most recently
from
0caeebd
to
2775b30
Compare
The Topic library is an event emitter with no consumers implemented. At our production sites, we do not even write to the database the events. Thus, this commit removes Topic until we have a real use case for it. Closes IMA-WorldHealth#3091
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 31, 2018
3105: chore: remove Topic r=jniles a=jniles The Topic library is an event emitter with no consumers implemented. At our production sites, we do not even write to the database the events. Thus, this commit removes Topic until we have a real use case for it. It should also improve performances slightly since we will not be Pub/Sub-ing events to Redis. Closes #3091. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 31, 2018
3105: chore: remove Topic r=jniles a=jniles The Topic library is an event emitter with no consumers implemented. At our production sites, we do not even write to the database the events. Thus, this commit removes Topic until we have a real use case for it. It should also improve performances slightly since we will not be Pub/Sub-ing events to Redis. Closes #3091. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Topic library is an event emitter with no consumers implemented. At our production sites, we do not even write to the database the events. Thus, this commit removes Topic until we have a real use case for it.
It should also improve performances slightly since we will not be Pub/Sub-ing events to Redis.
Closes #3091.