Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bitstring from Lo Sci DE data class #359

Closed
sdhoyt opened this issue Mar 8, 2024 · 0 comments · Fixed by #397
Closed

Remove Bitstring from Lo Sci DE data class #359

sdhoyt opened this issue Mar 8, 2024 · 0 comments · Fixed by #397
Labels
enhancement New feature or request Ins: Lo Related to the IMAP-Lo instrument Level: L1 Level 1 processing

Comments

@sdhoyt
Copy link
Contributor

sdhoyt commented Mar 8, 2024 •
edited
Loading

Summary

Bitstring should be removed from the Lo Sci DE data class to improve algorithm speed. The Direct event binary should be left as a string and the decompression algorithms should iterate over the string rather than creating a bitstream.

File: https://github.com/IMAP-Science-Operations-Center/imap_processing/blob/dev/imap_processing/lo/l0/science_direct_events.py
@sdhoyt sdhoyt added enhancement New feature or request Ins: Lo Related to the IMAP-Lo instrument Level: L1 Level 1 processing labels Mar 8, 2024
@sdhoyt sdhoyt linked a pull request Apr 19, 2024 that will close this issue
Science Direct Event Decompression Re-write #397
Merged
@sdhoyt sdhoyt closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Ins: Lo Related to the IMAP-Lo instrument Level: L1 Level 1 processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Science Direct Event Decompression Re-write sdhoyt/imap_processing
1 participant
@sdhoyt