Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to IDEX L1 code for consistency #656

Closed
bourque opened this issue Jun 21, 2024 · 1 comment · Fixed by #695
Closed

Updates to IDEX L1 code for consistency #656

bourque opened this issue Jun 21, 2024 · 1 comment · Fixed by #695
Assignees
Labels
Ins: IDEX Related to the IDEX instrument Level: L0 Level 0 processing Level: L1 Level 1 processing Student Tasks suitable for student work

Comments

@bourque
Copy link
Collaborator

bourque commented Jun 21, 2024

There are a few updates we can make to the IDEX L1 code to be more consistent with other instruments' pipelines:

  • Generate an updated packet definition file with recent version of space_packet_parser
  • Separate out the L0 decommutation code and the L1 processing code within idex_packet_parser.py, and update unit tests accordingly
  • Switch CDF attribute definitions to use yaml files instead of dataclasses
  • Add call to write_cdf() within pipeline so that CDFs get created within the pipeline, instead of within cli.py
@bourque bourque added Ins: IDEX Related to the IDEX instrument Level: L0 Level 0 processing Level: L1 Level 1 processing Student Tasks suitable for student work labels Jun 21, 2024
@subagonsouth
Copy link
Contributor

You may want to hold off on that final bullet. I think that @greglucas had some compelling reasons as to why the pipelines should not be calling write_cdf().

@bourque bourque added this to IMAP Jul 12, 2024
@anamanica anamanica self-assigned this Jul 12, 2024
@bourque bourque moved this to In Progress in IMAP Jul 15, 2024
@anamanica anamanica mentioned this issue Jul 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in IMAP Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: IDEX Related to the IDEX instrument Level: L0 Level 0 processing Level: L1 Level 1 processing Student Tasks suitable for student work
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants