Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poetry for dependency management #180

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Use poetry for dependency management #180

merged 1 commit into from
Apr 15, 2022

Conversation

kmrinal19
Copy link
Contributor

No description provided.

@dhruvkb
Copy link
Member

dhruvkb commented Apr 5, 2022

Good! I'm interested to know the reasons for the switch.

@kmrinal19
Copy link
Contributor Author

Good! I'm interested to know the reasons for the switch.

While adding new packages to omniport recently, few problems that we noticed with pipenv:

  • Failure in resolving the dependencies sometimes
  • Locking time was way too long
  • Vague error messages

These problems made us look for a new dependency manager, and poetry seemed like a good fit for our use case.

@pradumangoyal
Copy link
Member

Want to mention: IMGIITRoorkee/omniport-docker/issues/30

@kmrinal19 kmrinal19 merged commit 22bfe06 into master Apr 15, 2022
@kmrinal19 kmrinal19 deleted the add-poetry branch April 15, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmrinal19 @dhruvkb @pradumangoyal