Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow actions for running tests; fixes #50 #52

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Conversation

thurber
Copy link
Contributor

@thurber thurber commented Jun 15, 2021

This update will cause Linux builds/tests to occur on any push, and OSX and Windows builds/tests to occur on any Pull Request.

FYI openjournals/joss-reviews#3313

@thurber thurber requested review from amandadsmith and crvernon June 15, 2021 18:36
@thurber
Copy link
Contributor Author

thurber commented Jun 15, 2021

i think the NOAA servers are struggling, so the download test is failing... will revisit this in a day or so

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a550a84). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b852427 differs from pull request most recent head e6bc54f. Consider uploading reports for the commit e6bc54f to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master      #52   +/-   ##
=========================================
  Coverage          ?   97.31%           
=========================================
  Files             ?       19           
  Lines             ?      708           
  Branches          ?        0           
=========================================
  Hits              ?      689           
  Misses            ?       19           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a550a84...e6bc54f. Read the comment docs.

@thurber
Copy link
Contributor Author

thurber commented Jun 16, 2021

okay @amandadsmith, @crvernon, after the prerequisite battle with building on windows, we now have continuous integration testing on commits and pull requests!

@thurber thurber merged commit 99c8459 into master Jul 13, 2021
@thurber thurber deleted the feature/ci branch July 13, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant