7차 과제 구현 완....료는 아니고 중..... #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
approved these changes
Dec 10, 2022
| adapter.setRepoList(userViewModel.userList) | ||
| Log.e("Response", "onResponse: ${userViewModel.userList}" ) | ||
| adapter.setMusicList(musicShowViewModel.musicList) | ||
| Log.e("Response", "onResponse: ${musicShowViewModel.musicList}" ) |
There was a problem hiding this comment.
Suggested change
| Log.e("Response", "onResponse: ${musicShowViewModel.musicList}" ) | |
| Log.d("Response", "onResponse: ${musicShowViewModel.musicList}" ) |
대개 e는 에러가 발생했을 때 사용하는거여서 d를 사용하는게 좋아
Comment on lines
+15
to
+16
| class MusicViewHolder(private val binding: ItemLayoutBinding) | ||
| : RecyclerView.ViewHolder(binding.root) { |
There was a problem hiding this comment.
Suggested change
| class MusicViewHolder(private val binding: ItemLayoutBinding) | |
| : RecyclerView.ViewHolder(binding.root) { | |
| class MusicViewHolder( | |
| private val binding: ItemLayoutBinding | |
| ) : RecyclerView.ViewHolder(binding.root) { |
Comment on lines
+18
to
+20
| binding.ivAlbum.load(data.image) | ||
| binding.tvTitle.text = data.title | ||
| binding.tvSinger.text = data.singer |
There was a problem hiding this comment.
Suggested change
| binding.ivAlbum.load(data.image) | |
| binding.tvTitle.text = data.title | |
| binding.tvSinger.text = data.singer | |
| with(binding) { | |
| ivAlbum.load(data.image) | |
| tvTitle.text = data.title | |
| tvSinger.text = data.singer | |
| } |
| } | ||
|
|
||
| override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) { | ||
| if (holder is MusicViewHolder) holder.setMusic(musicList[position]) |
There was a problem hiding this comment.
Suggested change
| if (holder is MusicViewHolder) holder.setMusic(musicList[position]) | |
| (holder is MusicViewHolder).let{ it.setMusic(musicList[position]) } |
이렇게도 작성할 수 있어!
There was a problem hiding this comment.
코틀린의 확장함수,, let, with, run, apply, also
시험끝나고 공부해 봐야지
Comment on lines
+42
to
+43
| map["request"] = "{\"title\": \"$title\", \"singer\": \"$singer\"}".toRequestBody("application/json".toMediaTypeOrNull()) | ||
| viewModel.addMusic(map) |
Comment on lines
+31
to
+37
| private fun idRegex(id : String) : Boolean{ | ||
| return id.matches("^(?=.*[A-Za-z])(?=.*[0-9])[A-Za-z[0-9]]{6,10}$".toRegex()) | ||
| } | ||
|
|
||
| private fun pwRegex(pw : String) : Boolean{ | ||
| return pw.matches("^(?=.*[A-Za-z])(?=.*[0-9])(?=.*[!@#$%^&*?])[A-Za-z[0-9]!@#\$%^&*?]{6,12}$".toRegex()) | ||
| } |
There was a problem hiding this comment.
Regex 객체는 생성할 때 비용이 커서 미리 변수로 만들어놓는게 좋을 것 같아!
Comment on lines
+45
to
+58
| edtSignupId.addTextChangedListener(object : TextWatcher{ | ||
| override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) {} | ||
| override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) {} | ||
| override fun afterTextChanged(s: Editable?) { | ||
| if(idRegex(edtSignupId.text.toString())){ | ||
| textinputlayoutId.error = null | ||
| idFlag = true | ||
| } | ||
| else{ | ||
| textinputlayoutId.error = "아이디 형식이 올바르지 않습니다." | ||
| } | ||
| flagCheck() | ||
| } | ||
| }) |
There was a problem hiding this comment.
Suggested change
| edtSignupId.addTextChangedListener(object : TextWatcher{ | |
| override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) {} | |
| override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) {} | |
| override fun afterTextChanged(s: Editable?) { | |
| if(idRegex(edtSignupId.text.toString())){ | |
| textinputlayoutId.error = null | |
| idFlag = true | |
| } | |
| else{ | |
| textinputlayoutId.error = "아이디 형식이 올바르지 않습니다." | |
| } | |
| flagCheck() | |
| } | |
| }) | |
| edtSignupId.doAfterTextChanged { | |
| if (idRegex(edtSignupId.text.toString())){ | |
| textinputlayoutId.error = null | |
| idFlag = true | |
| } | |
| else { | |
| textinputlayoutId.error = "아이디 형식이 올바르지 않습니다." | |
| } | |
| flagCheck() | |
| } | |
| } |
doAfterTextChanged 사용하면 좀 더 깔끔할 듯?
| @POST("music") | ||
| fun addMusic( | ||
| @Part image : MultipartBody.Part?, | ||
| @Part ("request") request: RequestBody |
There was a problem hiding this comment.
Suggested change
| @Part ("request") request: RequestBody | |
| @Part request: RequestBody |
Comment on lines
+44
to
+46
| <meta-data | ||
| android:name="android.app.lib_name" | ||
| android:value="" /> |
Comment on lines
+21
to
+22
| private val musicShowService = MusicServicePool.musicShowService | ||
| private val musicShowViewModel by viewModels<MusicShowViewModel>() |
There was a problem hiding this comment.
홈 프래그먼트 버리고 이거로 바꿨네 ㅋㅋㅋㅋ 안아까워??
| import okhttp3.RequestBody.Companion.toRequestBody | ||
| import org.sopt.sample.MainActivity | ||
|
|
||
| class MusicAddActivity : AppCompatActivity() { |
Comment on lines
+3
to
+9
| <!-- TODO: Remove or change this placeholder text --> | ||
| <string name="hello_blank_fragment">Hello blank fragment</string> | ||
| <string name="inputId">제목을 입력하세요</string> | ||
| <string name="inputPw">비밀번호를 입력하세요</string> | ||
| <string name="inputName">이름을 입력하세요</string> | ||
| <string name="inputTitle">노래제목을 입력하세요</string> | ||
| <string name="inputSinger">가수를 입력하세요</string> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map이 안된다는.... 사실을..... 11시 40분에 알았다는....