Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify loading from prefixmaps #47

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Simplify loading from prefixmaps #47

merged 5 commits into from
Dec 5, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Nov 23, 2023

No description provided.

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 28, 2023

@hrshdhgd this is a very small change, can you please enable CI and if there are no issues, merge? thanks!

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 28, 2023

hmm, looks like we'll need to update prefixmaps

@cthoyt
Copy link
Contributor Author

cthoyt commented Dec 5, 2023

@hrshdhgd updating prefixmaps solves the problem. Can you approve running this on CI?

@hrshdhgd hrshdhgd requested a review from cmungall December 5, 2023 16:07
@cmungall cmungall merged commit 24b3895 into INCATools:main Dec 5, 2023
6 checks passed
@cthoyt
Copy link
Contributor Author

cthoyt commented Dec 5, 2023

Thanks @cmungall. It would be great to get a release on this so we can update several other PRs waiting on this

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Dec 5, 2023

Done!

@cthoyt
Copy link
Contributor Author

cthoyt commented Dec 5, 2023

cheers @hrshdhgd , much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthoyt @hrshdhgd @cmungall