Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node_id and replace with about_node for ClassCreation and NodeCreation #81

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Aug 15, 2024

Fixes INCATools/ontology-access-kit#790

Before this fix: ClassCreation KGCL output reflects create None since the render operation assigns the value to node_id but downstream we're assigning the value to about_node. about_node seems consistent with all other classes.

@hrshdhgd hrshdhgd merged commit 8a62f0e into main Aug 15, 2024
6 checks passed
@hrshdhgd hrshdhgd deleted the h2-patch-2 branch August 15, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff in KGCL format generates create None.
2 participants