-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBO Compliance suite (replay of 683) #693
Conversation
cmungall
commented
Dec 21, 2023
- First pass at oboformat and obographs conformance suite.
- Allow choice of format when exporting OWL. Addung missing features to obo conversion
- lint
- lint
- Lint. Removing prints.
- Added format_utilities.py -- see Dumpers and loaders: Separate concept of syntax and datamodel #687
- adding test failure info
- reconciled dumper changes between branches
This passes locally but fails on acitons, likely some kind of nondeterminism in ordering... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a bit too big to carefully review for me, so I will trust that it wont result in any breaking. However, can you add a section to the OAK docs on "How to test a new OBOgraphs release with OAK"?
I can see the tests in test_obo_format.py, but I cannot easily imagine the recipe.
- New OBO graphs version for testing available
- Compile to JAR
- Compile new ROBOT JAR with that test version of OBO graphs
- Run...
- If X then all is well and we can make an OBO graphs release and push it into ROBOT
A recipe like this would be very useful.
There are also two files
tests/input/obo_conf.yaml
tests/input/obojson_conf.yaml
that are generated as part of a local run. Should these be committed or gitignored?
See - owlcollab/oboformat#146 - geneontology/obographs#106 Note that that may move from the OAK repo in the longer term.
Addung missing features to obo conversion
bf66582
to
2932166
Compare
Works for me locally:
But this fails on actions |
Closed in favor of #715 |
* First pass at oboformat and obographs conformance suite. See - owlcollab/oboformat#146 - geneontology/obographs#106 Note that that may move from the OAK repo in the longer term. * Allow choice of format when exporting OWL. Addung missing features to obo conversion * lint * lint * Lint. Removing prints. * Added format_utilities.py -- see #687 * lint * Fixing spelling mistakes * dumper * Fixed tests and dumper --------- Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>