Update examples #24
Merged
Update examples #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2021
|
@stinebuu a review on the basis of whether it works for you is fine here I think, no need to go through the code changes. |
stinebuu
reviewed
Dec 3, 2021
| @@ -261,7 +261,7 @@ def plot_fractions(self, axis, fill_variables, | |||
| matplotlib.ticker.ScalarFormatter()) | |||
|
|
|||
| def plot_main(self, quantities, axis, log=(False, False), | |||
| error=False): | |||
| error=False, fmt='none'): | |||
There was a problem hiding this comment.
Could you add a comment about what fmt is in the Attributes list?
There was a problem hiding this comment.
Like this? (see bench_plot.py)
stinebuu
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the examples to work with the new(-ish) plotting routines. Mainly, they move away from the deprecated
catalogue.yamland work directly with.csvfiles. Fixes #19.