Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirements #19

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Add requirements #19

merged 1 commit into from
Nov 23, 2021

Conversation

jasperalbers
Copy link
Collaborator

@jasperalbers jasperalbers commented Nov 19, 2021 •
edited
Loading

Adds requirements.txt specifying python dependencies.

@jasperalbers jasperalbers added the enhancement New feature or request label Nov 19, 2021
@jasperalbers jasperalbers linked an issue Nov 19, 2021 that may be closed by this pull request
Specify requirements for Python code #17
Closed
jhnnsnk
jhnnsnk reviewed Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is nbconvert==6.1.0 required or could the == be replaced by a >=?

@jasperalbers
Copy link
Collaborator Author

In my experience a newer version does not work.

jhnnsnk
jhnnsnk approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Then we keep the explicit version number for now.
👍

@jasperalbers jasperalbers merged commit 7ed55a4 into main Nov 23, 2021
@jasperalbers jasperalbers deleted the requirements branch November 23, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnnsnk jhnnsnk jhnnsnk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify requirements for Python code
2 participants
@jasperalbers @jhnnsnk