Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection of timer information #42

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

jarsi
Copy link
Collaborator

@jarsi jarsi commented Dec 16, 2021

The PR 3 of [beNNch-models]((https://github.com/INM-6/beNNch-models/) changed the content of the logging files: They now also contain all of the nest.GetKernelStatus() dictionary. This leads to problems when collecting the timer information: 1) The content of a line can possibly have more than two entries. 2) Not all entries are of interest for further timer analysis.

This PR fixes both problems. Any entry that does not fit into the key, value scheme is written into a throwaway list. Any entry that is not part of the metrics of interest is disregarded.

I have tried it with the microcircuit but I don't see a reason why it should behave differently with the other models.

@jasperalbers jasperalbers added the bug Something isn't working label Dec 17, 2021
@jasperalbers jasperalbers self-requested a review December 17, 2021 16:30
Copy link
Collaborator

@jasperalbers jasperalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I can do tests for other models after christmas and will make issues/follow-up PRs if necessary.

@jasperalbers jasperalbers merged commit 2f1faea into main Dec 17, 2021
@jasperalbers jasperalbers deleted the repair_collect_timer_data branch December 17, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants