New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clean-up #48

Merged

jasperalbers merged 3 commits into INM-6:main from stinebuu:mam

Feb 9, 2022

Contributor

stinebuu commented Jan 27, 2022

This PR

updates benchmarks/multi-area-model_{}.yaml to use the correct num_vps
updates comment on scaling_type in analysis_config_template.yaml (I always think it refers to weak or strong scaling)
clean up hpc_benchmark_config_template.yaml, removing an unused parameter and updating a comment

stinebuu added 3 commits

January 27, 2022 08:46


          totVPs is now called num_vps

37bad1f


          update comment on scaling_type for analysis config type

7a0213c


          clean up hpc_benchmark_config_template

fafe594

jasperalbers self-requested a review

February 9, 2022 12:10

jasperalbers approved these changes

View reviewed changes

Collaborator

jasperalbers left a comment

Great catches, all of them look good!

jasperalbers merged commit 1973992 into INM-6:main

stinebuu deleted the mam branch

February 9, 2022 13:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet