Remove duplicate hero image on posts, update largo_byline on older templates

[benlk]

Changes

This pull request makes the following changes:

• Comments out largo_hero() call in the single-two-column.php template added for Create article template, style header #99
• Updates the existing partials/content-single-classic.php and partials/content-single.php added in Remove featured media from single post templates #5 for compatibility with Largo 0.6.4 by adding the post ID to largo_byline() calls, in accordance with Should largo_byline require an explicit post to be specified? WPBuddy/largo#1517
• Adds the post ID to all other largo_byline() calls in this theme
• Correct capitalization on all get_post_id() calls to get_post_ID(), to match the function declaration https://developer.wordpress.org/reference/functions/get_the_ID/

Why

For #124

Testing/Questions

Features that this PR affects:

• Article content

Questions that need to be answered before merging:

• Is this PR targeting the correct branch in this repository?
• does it work?

Steps to test this PR:

1. Check it out.

[joshdarby]

@benlk I'm confused (probably because I don't have any background knowledge on the way they've been using featured media like you do), but wasn't the idea to use a built in Largo filter that would remove the image in the post if it matched the featured image, instead of just removing the largo_hero all together?

[benlk]

The filter is presently removed from effect in

umbrella-citylimits/wp-content/themes/citylimits/inc/post-templates.php

Lines 20 to 23 in 1c2dbaa

	function citylimits_remove_largo_remove_hero() {
	remove_filter( 'the_content', 'largo_remove_hero', 1 );
	}
	add_action( 'init', 'citylimits_remove_largo_remove_hero' );

, but I'm still seeing the media credits output upon the page. I'm going to download the relevant assets to see if the reason the filter is failing is because the image tags aren't being output due to lack of image.

[benlk]

tl;dr: I have discovered today that the filter doesn't work on Gutenberg content. I'm writing up the rest of the problem in an issue in Largo. It boils down to the assumptions we made about those images' markup no longer being correct, in a https://stackoverflow.com/a/1732454 sort of way.

Largo issue: WPBuddy/largo#1834

[benlk]

@joshdarby With WPBuddy/largo#1834 being the case, this PR's removal of largo_hero():

• works (hopefully)
• is maintainable

[joshdarby]

@benlk I'm fine with it, but we may want to write out a more in-depth tldr for @MirandaEcho and @kaylima so there's no confusion about images moving forward.

[benlk]

I don't think there's actually going to be any change for City Limits going forward; this is just making sure that the new article template continues the behavior of the past article templates.