-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin for the custom post type for Projects #131
Conversation
As I'm working through the import process testing, I realized that this is missing one post meta field, now added to #119 (comment): The project link. |
@benlk Since this is a pretty large project, maybe we should merge this (and every other PR for the project) into |
I would prefer if we finish creating the custom metaboxes. Leaving the custom fields editor open for anyone to use will probably cause us lots of headaches in the future. For example, I can see someone going to add in a value for an accepted field that's not yet included in the current project, for example @MirandaEcho any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- form submission to project post type works well
- no weird errors
- taxonomies function as expected
- REST endpoint for
projects
works - REST endpoints for taxonomies works
My only concern is the custom metabox question, and I also don't have a good answer (yet) about whether or not we want to use auth_callback
.
I've updated |
Issue created to capture the outstanding metabox work: #133 |
Changes
This pull request adds a plugin with the following registrations
projects
Why
For #119.
Built as a plugin to enhance future portability of this database, and to keep this concern separate from the child theme if they ever decide to swap away from their current theme.
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR: