Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal qa updates #149

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Internal qa updates #149

merged 4 commits into from
Jun 9, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Jun 9, 2020

Changes

This pull request makes the following changes:

  • Makes 0.5rem margin be on all tags on the list holder items instead of all but the first and switches it from margin-left to margin-right so it's inline with the content
  • Adds 6px left and right padding to project statuses on the single view
  • Adds 1rem bottom margin to images and videos
    Screen Shot 2020-06-09 at 2 01 03 PM
  • Makes expanded category holder 175px wide instead of 100% so it doesn't cover everything
    Screen Shot 2020-06-09 at 1 54 38 PM
  • Adds support for excerpt in projects custom post type

Why

For #143

Testing/Questions

Features that this PR affects:

  • Tags/categories on the list items
  • Images and videos
  • Category filter
  • Project excerpt field

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. Poke around and make sure everything looks ok
  2. Make sure the excerpt field is visible in the project post editor

@joshdarby joshdarby added this to the INOV-001 milestone Jun 9, 2020
@joshdarby joshdarby requested review from benlk and MirandaEcho June 9, 2020 17:56
@joshdarby joshdarby self-assigned this Jun 9, 2020
@joshdarby joshdarby merged commit 68e7eb0 into staging Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants