fix:avoid crash in hasImplicitAncestor (#3247)

INRIA · Feb 17, 2020 · 098cb9b · 098cb9b
1 parent 0e5dfe4
commit 098cb9b
Show file tree

Hide file tree

Showing 5 changed files with 93 additions and 2 deletions.
diff --git a/src/main/java/spoon/support/compiler/jdt/JDTTreeBuilderHelper.java b/src/main/java/spoon/support/compiler/jdt/JDTTreeBuilderHelper.java
@@ -516,7 +516,6 @@ private static void handleImplicit(PackageBinding packageBinding, char[][] token
 					 * (e.g. spoon.test.imports.testclasses.internal.ChildClass.InnerClassProtected)
 					 * In such rare case we cannot detect and set implicitness
 					 */
-					typeRef.getFactory().getEnvironment().debugMessage("Compiler's type path: " + qualifiedNameReference + " doesn't matches with Spoon qualified type name: " + originTypeRef);
 					return;
 					//throw new SpoonException("Unexpected type reference simple name: \"" + token + "\" expected: \"" + typeRef.getSimpleName() + "\"");
 				}

diff --git a/src/main/java/spoon/support/sniper/SniperJavaPrettyPrinter.java b/src/main/java/spoon/support/sniper/SniperJavaPrettyPrinter.java
@@ -183,7 +183,7 @@ private void pushContext(SourceFragmentPrinter listContext) {
 
 
 	private static boolean hasImplicitAncestor(CtElement el) {
-		if (el == null) {
+		if (el == null || !el.isParentInitialized()) {
 			return false;
 		}
 		if (el == el.getFactory().getModel().getRootPackage()) {

diff --git a/src/test/java/spoon/processing/ProcessingTest.java b/src/test/java/spoon/processing/ProcessingTest.java
@@ -19,6 +19,7 @@
 import org.junit.Test;
 import spoon.Launcher;
 import spoon.compiler.Environment;
+import spoon.reflect.code.CtBlock;
 import spoon.reflect.declaration.CtType;
 import spoon.support.sniper.SniperJavaPrettyPrinter;
 import spoon.test.processing.processors.MyProcessor;

diff --git a/src/test/java/spoon/test/parent/ParentTest.java b/src/test/java/spoon/test/parent/ParentTest.java
@@ -20,7 +20,9 @@
 import org.junit.Ignore;
 import org.junit.Test;
 import spoon.Launcher;
+import spoon.compiler.Environment;
 import spoon.compiler.SpoonResourceHelper;
+import spoon.support.sniper.SniperJavaPrettyPrinter;
 import spoon.test.intercession.IntercessionScanner;
 import spoon.reflect.code.BinaryOperatorKind;
 import spoon.reflect.code.CtAssignment;
@@ -57,6 +59,9 @@
 import spoon.support.UnsettableProperty;
 import spoon.test.replace.testclasses.Tacos;
 
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.ArrayDeque;
 import java.util.Deque;
 import java.util.List;
@@ -410,4 +415,21 @@ public boolean matches(CtInvocation<?> element) {
 		}.scan(launcher.getModel().getRootPackage());
 	}
 
+
+	@Test
+	public void testParentNotInitializedException() throws IOException {
+		// contract: does not crash on hasImplicitParent
+		final Launcher l = new Launcher();
+		Environment e = l.getEnvironment();
+
+		e.setNoClasspath(true);
+		e.setAutoImports(true);
+		e.setPrettyPrinterCreator(() -> new SniperJavaPrettyPrinter(l.getEnvironment()));
+
+		Path path = Files.createTempDirectory("emptydir");
+		l.addInputResource("src/test/resources/compilation4/A.java");
+		l.setSourceOutputDirectory(path.toFile());
+		l.run();
+	}
+
 }
diff --git a/src/test/resources/compilation4/A.java b/src/test/resources/compilation4/A.java
@@ -0,0 +1,69 @@
+package me.ccrama.redditslide;
+/**
+ * Created by ccrama on 9/19/2015.
+ */
+public class A extends android.os.AsyncTask<net.dean.jraw.models.PublicContribution, java.lang.Void, java.lang.Void> {
+    private final net.dean.jraw.models.VoteDirection direction;
+
+    private android.view.View v;
+
+    private android.content.Context c;
+
+    public A(java.lang.Boolean b, android.view.View v, android.content.Context c) {
+        direction = (b) ? net.dean.jraw.models.VoteDirection.UPVOTE : net.dean.jraw.models.VoteDirection.DOWNVOTE;
+        this.v = v;
+        this.c = c;
+        me.ccrama.redditslide.Reddit.setDefaultErrorHandler(c);
+    }
+
+    public A(android.view.View v, android.content.Context c) {
+        direction = net.dean.jraw.models.VoteDirection.NO_VOTE;
+        this.v = v;
+        this.c = c;
+    }
+
+    @java.lang.Override
+    protected java.lang.Void doInBackground(net.dean.jraw.models.PublicContribution... sub) {
+        if (me.ccrama.redditslide.Authentication.isLoggedIn) {
+            try {
+                new net.dean.jraw.managers.AccountManager(me.ccrama.redditslide.Authentication.reddit).vote(sub[0], direction);
+            } catch (net.dean.jraw.ApiException | java.lang.RuntimeException e) {
+                ((android.app.Activity) (c)).runOnUiThread(new java.lang.Runnable() {
+                    public void run() {
+                        try {
+                            if (((v != null) && (c != null)) && (v.getContext() != null)) {
+                                android.support.design.widget.Snackbar s = android.support.design.widget.Snackbar.make(v, me.ccrama.redditslide.R.string.vote_err, android.support.design.widget.Snackbar.LENGTH_SHORT);
+                                android.view.View view = s.getView();
+                                android.widget.TextView tv = ((android.widget.TextView) (view.findViewById(android.support.design.R.id.snackbar_text)));
+                                tv.setTextColor(android.graphics.Color.WHITE);
+                                s.show();
+                            }
+                        } catch (java.lang.Exception ignored) {
+                        }
+                        c = null;
+                        v = null;
+                    }
+                });
+                e.printStackTrace();
+            }
+        } else {
+            ((android.app.Activity) (c)).runOnUiThread(new java.lang.Runnable() {
+                public void run() {
+                    try {
+                        if (((v != null) && (c != null)) && (v.getContext() != null)) {
+                            android.support.design.widget.Snackbar s = android.support.design.widget.Snackbar.make(v, me.ccrama.redditslide.R.string.vote_err_login, android.support.design.widget.Snackbar.LENGTH_SHORT);
+                            android.view.View view = s.getView();
+                            android.widget.TextView tv = ((android.widget.TextView) (view.findViewById(android.support.design.R.id.snackbar_text)));
+                            tv.setTextColor(android.graphics.Color.WHITE);
+                            s.show();
+                        }
+                    } catch (java.lang.Exception ignored) {
+                    }
+                    c = null;
+                    v = null;
+                }
+            });
+        }
+        return null;
+    }
+}