fix: Stop adding duplicated modules when cloning them (#4747)

src/main/java/spoon/reflect/factory/ModuleFactory.java

@@ -128,6 +128,7 @@ public CtModule getOrCreate(String moduleName) {
 			ctModule = factory.Core().createModule().setSimpleName(moduleName);
 			ctModule.setRootPackage(new CtModelImpl.CtRootPackage());
 			ctModule.setParent(getUnnamedModule());
+			getUnnamedModule().addModule(ctModule);
 		}
 
 		return ctModule;

src/main/java/spoon/support/DefaultCoreFactory.java

@@ -1124,7 +1124,7 @@ public CtTypeMemberWildcardImportReference createTypeMemberWildcardImportReferen
 	public CtModule createModule() {
 		CtModule module = new CtModuleImpl();
 		module.setFactory(getMainFactory());
-		this.getMainFactory().Module().getUnnamedModule().addModule(module);
+		module.setParent(this.getMainFactory().Module().getUnnamedModule());
 		return module;
 	}
 

src/test/java/spoon/test/module/TestModule.java

@@ -407,4 +407,17 @@ public void testModuleOverlappingPackages() {
 		);
 		assertNotNull(launcher.getFactory().Type().get("test.parent.nested.Foo"), "");
 	}
+
+	@Test
+	public void testModulePrintDoesNotDuplicate() {
+		// contract: Printing a module does not duplicate it in Model#getAllModules()
+		Launcher launcher = new Launcher();
+		launcher.getEnvironment().setComplianceLevel(9);
+		launcher.addInputResource(MODULE_RESOURCES_PATH + "/code-multiple-modules");
+		CtModel ctModel = launcher.buildModel();
+		assertEquals(3, ctModel.getAllModules().size());
+		//noinspection ResultOfMethodCallIgnored   I wish it had no effect too, unspecified static analysis tool
+		launcher.getFactory().Module().getModule("bar").toString();
+		assertEquals(3, ctModel.getAllModules().size());
+	}
 }