Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CtScanner.visitCtAnnotation() shouldn't iterate over annotation.getElementValues().values() manually #603

Closed
leventov opened this issue Apr 19, 2016 · 2 comments · Fixed by #614
Closed

CtScanner.visitCtAnnotation() shouldn't iterate over annotation.getElementValues().values() manually #603

leventov opened this issue Apr 19, 2016 · 2 comments · Fixed by #614

Comments

@leventov
Copy link
Contributor

Instead, it should delegate to genetic scan(Collection) method. This allows to override just scan(Collection) in some subclass of CtScanner and enjoy same behaviour for any elements (e. g. hashCodeVisitor from here: #601 (comment) do this).

In CtScanner, visitCtAnnotation() is the only method where this rule is violated.
@monperrus
Copy link
Collaborator

Could you write a PR? Thanks.

@GerardPaligot
Copy link
Contributor

I found this bug too when I developed my refactoring of replacing elements. @leventov you can write a PR or wait for my PR.

leventov added a commit to leventov/spoon that referenced this issue Apr 22, 2016
@leventov
Fix a defect in CtScanner.visitCtAnnotation(): annotation values trav…
fead4fb 
…ersal should be delegated to scan(), fixes INRIA#603
@leventov leventov mentioned this issue Apr 22, 2016
Merged
@tdurieux tdurieux mentioned this issue Jun 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a defect in CtScanner.visitCtAnnotation(): annotation values trav… leventov/spoon
3 participants
@leventov @monperrus @GerardPaligot