fix(ThisAccess): the type access associated to a this must be the type containing the this #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
force-pushed
the
fix-implicit-this
branch
from
ca457ce
to
8bdca49
Compare
tdurieux
reviewed
Nov 28, 2016
| @@ -85,4 +90,26 @@ public void testGetAllMethods() throws Exception { | |||
| assertEquals(1, methods.stream().filter(method -> "foo".equals(method.getSimpleName())).count()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCloneMethodUsingjlObjectMethods() throws Exception { | |||
There was a problem hiding this comment.
What does the jl mean in this test name? testCloneMethodUsingjlObjectMethods
There was a problem hiding this comment.
Maybe java.lang.Object?
monperrus
force-pushed
the
fix-implicit-this
branch
from
8bdca49
to
6517159
Compare
…e containing the this fixes INRIA#1006. Note that INRIA#1006 was neither in clone, nor in pretty-printer, but in the model. This is the problem when implicit=true, the model can be incorrect and one does not see it.
monperrus
force-pushed
the
fix-implicit-this
branch
from
6517159
to
b754654
Compare
|
fixed test name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1006.
Note that #1006 was neither in clone, nor in pretty-printer, but in the model.
This is the problem when implicit=true, the model can be incorrect and one does not see it.